Make `Sized` coinductive, again #100386

compiler-errors · 2022-08-10T19:01:56Z

A revival of #83647

What exactly makes co-induction sound? Better question: are there any unsoundness risks from this? Sized can't be implemented by custom impl blocks, nor can it be conditionally implemented based on anything other than child fields being Sized, right?

r? @nikomatsakis for whenever he gets back from vacation

bors · 2022-08-19T00:40:20Z

☔ The latest upstream changes (presumably #98807) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2022-09-06T20:35:40Z

I think we should do this, but I think it requires an FCP.

The soundness challenges with coinduction are tied to elaborated bounds, which don't apply to Sized as it has no supertraits.

Ideally we'd have an RFC for moving all trait matching to coinduction.

compiler-errors · 2022-09-12T03:35:48Z

Since exploring moving all traits to be coinductive is significantly harder and likely requires an RFC/opt-in/migration/etc., I'm following Nikos'a advice above and proposing merging just this for now.

@rfcbot merge

rfcbot · 2022-09-12T03:35:49Z

Team member @compiler-errors has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

~~does this limit Sized having supertrait predicates (like trait Thin =Pointee<Metadata = ()>) in the future?~~ resolved by Make Sized coinductive, again #100386 (comment)

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

nikomatsakis · 2022-09-12T15:12:14Z

@rfcbot reviewed

rfcbot · 2022-09-12T15:12:21Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2022-09-13T13:08:35Z

☔ The latest upstream changes (presumably #96709) made this pull request unmergeable. Please resolve the merge conflicts.

madsmtm · 2022-09-16T13:00:10Z

don't apply to Sized as it has no supertraits.

Just wanted to note that it is being considered in #81513 to add Thin as a supertrait of Sized.

I don't know anything about coinduction, but if the only reason this is sound is that Sized has no supertraits, then you may want to reconsider doing this?

compiler-errors · 2022-09-17T00:44:47Z

@madsmtm:

I'm not sure if it makes sense to add Thin as a supertrait of Sized nowadays -- the Pointee trait is implemented for all types, but there is special logic in the compiler to make sure that T: Sized => T: Thin without needing to enforce that relationship as a supertrait (#93977).

I'm not aware of any benefits of that relationship being reflected as a supertrait relationship, other than simplifying some of the builtin trait code... I can put that in as a concern and raise it up at a T-types meeting though.

compiler-errors · 2022-09-17T00:45:28Z

@rfcbot concern does this limit Sized having supertrait predicates (like trait Thin =Pointee<Metadata = ()>) in the future?

compiler-errors · 2022-09-17T00:48:36Z

(Presumably not -- we could work around this with the same modifications to the trait system as we need to enable coinduction for all traits, which we eventually do want. But it would be a shame to block a library feature that many people want on a trait system modification.)

Jules-Bertholet · 2022-10-02T03:52:16Z

rust-lang/rfcs#3319 would add Aligned as a supertrait of Sized.

nikomatsakis · 2022-10-10T21:14:07Z

In general, having supertrait predicates is not a concern, but we will have to do some work on our trait system implementation before we can properly handle it.

compiler-errors · 2022-10-13T03:54:17Z

@nikomatsakis, do you think we should block this due to possible RFCs adding supertrait bounds to Sized? I'm not sure if I have a strong opinion on this.

lcnr · 2022-10-26T08:10:24Z

I don't think we should block this on adding a super trait. Making Sized coinductive rn has a noticeable positive impact as it is necessary to abstract over collections for recursive structures, see src/test/ui/sized/coinductive-2.rs added in this PR.

We intend to support super traits for coinductive types in the future anyways and I expect us to be able to deal with this once necessary.

compiler-errors · 2022-10-27T02:04:51Z

@rfcbot resolve does this limit Sized having supertrait predicates (like trait Thin =Pointee<Metadata = ()>) in the future?

lcnr · 2022-11-07T06:39:42Z

r? @lcnr

lcnr · 2022-11-07T06:45:29Z

Should mention this in the full relnotes. This PR changes Sized obligations to be coinductive. This means that if the trait solver encounters a cycle which only includes auto traits and now Sized, it returns "Success" instead of an error.

An example would be

struct Node<C: Trait<Self>>(C::Assoc);

trait Trait<T> {
    type Assoc;
}

impl<T> Trait<T> for Vec<()> {
    type Assoc = Vec<T>;
}

fn main() {
    let _ = Node::<Vec<()>>(Vec::new());
}

Node<Vec<()>> is Sized if <Vec<()> as Trait<Node<Vec<()>>>::Assoc is Sized. After normalization, this requires Vec<Node<Vec<()>> to be Sized. Vec<Node<Vec<()>> again requires Node<Vec<()>> to be Sized, resulting in a cycle. As Sized is now coinductive, this does not result in an error anymore.

src/test/ui/sized/coinductive-1.rs

compiler-errors · 2022-11-11T04:03:41Z

whoops I forgot to approve this after I rebased

@bors r=lcnr

bors · 2022-11-11T04:03:43Z

📌 Commit fea8d0e has been approved by lcnr

It is now in the queue for this repository.

…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Pkgsrc changes: * Adjust patches and cargo checksums to new versions, but also one strange "mips" conditional. Upstream changes: Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

internal: support `#[rustc_coinductive]` rust-lang/rust#100386 changed the trait solver so that `Sized` is treated as coinductive trait, just like auto traits. This is now controlled by the perma-unstable `#[rustc_coinductive]` attribute (rust-lang/rust#108033), which this PR adds support for. In practice, I don't think this matters much if at all. Currently we don't give chalk enough information so chalk cannot precisely (dis)prove `Sized` bounds.

rust-highfive assigned nikomatsakis Aug 10, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 10, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2022

compiler-errors force-pushed the sized-coinductive-redux branch from 6045abe to 3220042 Compare September 12, 2022 03:34

compiler-errors added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 12, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 12, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 17, 2022

compiler-errors force-pushed the sized-coinductive-redux branch from 3220042 to 3e01e46 Compare October 25, 2022 17:59

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Oct 27, 2022

rustbot assigned lcnr and unassigned nikomatsakis Nov 7, 2022

lcnr added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 7, 2022

lcnr reviewed Nov 7, 2022

View reviewed changes

src/test/ui/sized/coinductive-1.rs Show resolved Hide resolved

lcnr and others added 4 commits November 10, 2022 21:18

make Sized coinductive

0f2e45b

add some more tests

8ec6c84

bless tests

43ad19b

More nits

fea8d0e

compiler-errors force-pushed the sized-coinductive-redux branch from 3e01e46 to fea8d0e Compare November 10, 2022 21:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022

Manishearth mentioned this pull request Nov 11, 2022

Rollup of 8 pull requests #104293

Merged

bors merged commit 76ce198 into rust-lang:master Nov 11, 2022

rustbot added this to the 1.67.0 milestone Nov 11, 2022

Alexendoo mentioned this pull request Nov 14, 2022

Inlined recursive type error can be dodged, leading to compiler overflowing its stack #98842

Closed

apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023

ExpHP mentioned this pull request Apr 1, 2023

Folds are not implemented for &hlist and &mut hlist lloydmeta/frunk#180

Open

lqd mentioned this pull request Apr 17, 2023

Unstable fingerprints for evaluate_obligation (EvaluatedToOkModuloRegions) #110416

Open

lowr mentioned this pull request Jun 25, 2023

internal: support #[rustc_coinductive] rust-lang/rust-analyzer#15125

Merged

compiler-errors deleted the sized-coinductive-redux branch August 11, 2023 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `Sized` coinductive, again #100386

Make `Sized` coinductive, again #100386

compiler-errors commented Aug 10, 2022

bors commented Aug 19, 2022

nikomatsakis commented Sep 6, 2022

compiler-errors commented Sep 12, 2022

rfcbot commented Sep 12, 2022 •

edited

Loading

nikomatsakis commented Sep 12, 2022

rfcbot commented Sep 12, 2022

bors commented Sep 13, 2022

madsmtm commented Sep 16, 2022

compiler-errors commented Sep 17, 2022

compiler-errors commented Sep 17, 2022

compiler-errors commented Sep 17, 2022

Jules-Bertholet commented Oct 2, 2022

nikomatsakis commented Oct 10, 2022

compiler-errors commented Oct 13, 2022

lcnr commented Oct 26, 2022

compiler-errors commented Oct 27, 2022

lcnr commented Nov 7, 2022

lcnr commented Nov 7, 2022

compiler-errors commented Nov 11, 2022

bors commented Nov 11, 2022

Make Sized coinductive, again #100386

Make Sized coinductive, again #100386

Conversation

compiler-errors commented Aug 10, 2022

bors commented Aug 19, 2022

nikomatsakis commented Sep 6, 2022

compiler-errors commented Sep 12, 2022

rfcbot commented Sep 12, 2022 • edited Loading

nikomatsakis commented Sep 12, 2022

rfcbot commented Sep 12, 2022

bors commented Sep 13, 2022

madsmtm commented Sep 16, 2022

compiler-errors commented Sep 17, 2022

compiler-errors commented Sep 17, 2022

compiler-errors commented Sep 17, 2022

Jules-Bertholet commented Oct 2, 2022

nikomatsakis commented Oct 10, 2022

compiler-errors commented Oct 13, 2022

lcnr commented Oct 26, 2022

compiler-errors commented Oct 27, 2022

lcnr commented Nov 7, 2022

lcnr commented Nov 7, 2022

compiler-errors commented Nov 11, 2022

bors commented Nov 11, 2022

Make `Sized` coinductive, again #100386

Make `Sized` coinductive, again #100386

rfcbot commented Sep 12, 2022 •

edited

Loading